]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
claims.idl: Use ‘int64’ instead of ‘dlong’ for INT64 claims
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Tue, 15 Aug 2023 00:31:54 +0000 (12:31 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 15 Aug 2023 18:46:33 +0000 (18:46 +0000)
This field is supposed to be aligned to eight bytes, but the ‘dlong’
type is aligned to only four bytes. This discrepancy resulted in claims
being encoded and decoded incorrectly.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15452

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
librpc/idl/claims.idl
selftest/knownfail.d/claims-in-pac [deleted file]

index 90ea15585c1f8b873d1a172118a5e91e0c0e82f9..196db5785a01e1d4d8411e3f344689250235078a 100644 (file)
@@ -50,7 +50,7 @@ interface claims
 
        typedef struct {
                [range(1, 10*1024*1024)] uint32 value_count;
-               [size_is(value_count)] dlong *values;
+               [size_is(value_count)] int64 *values;
        } CLAIM_INT64;
 
        typedef struct {
diff --git a/selftest/knownfail.d/claims-in-pac b/selftest/knownfail.d/claims-in-pac
deleted file mode 100644 (file)
index 4fc9abc..0000000
+++ /dev/null
@@ -1 +0,0 @@
-^samba\.tests\.krb5\.claims_in_pac\.samba\.tests\.krb5\.claims_in_pac\.PacClaimsTests\.test_pac_int64_claims\(none\)$