]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
media: venus: fix QCOM_MDT_LOADER dependency
authorArnd Bergmann <arnd@arndb.de>
Mon, 30 Mar 2026 11:08:21 +0000 (12:08 +0100)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Mon, 27 Apr 2026 06:41:21 +0000 (08:41 +0200)
When build-testined with CONFIG_QCOM_MDT_LOADER=m and VIDEO_QCOM_VENUS=y,
the kernel fails to link:

x86_64-linux-ld: drivers/media/platform/qcom/venus/firmware.o: in function `venus_boot':
firmware.c:(.text+0x1e3): undefined reference to `qcom_mdt_get_size'
firmware.c:(.text+0x25a): undefined reference to `qcom_mdt_load'
firmware.c:(.text+0x272): undefined reference to `qcom_mdt_load_no_init'

The problem is the conditional 'select' statement. Change this to
make the driver built-in here regardless of CONFIG_ARCH_QCOM,
same as for the similar IRIS driver.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
Fixes: 0399b696f7f4 ("media: venus: fix compile-test build on non-qcom ARM platform")
Cc: stable@vger.kernel.org
Signed-off-by: Bryan O'Donoghue <bod@kernel.org>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/platform/qcom/venus/Kconfig

index ffb731ecd48c907f52627cd761d723a68dac2a6a..63ee8c78dc6d7582314e3b70b449ed3acdbc4a2f 100644 (file)
@@ -4,7 +4,7 @@ config VIDEO_QCOM_VENUS
        depends on VIDEO_DEV && QCOM_SMEM
        depends on (ARCH_QCOM && ARM64 && IOMMU_API) || COMPILE_TEST
        select OF_DYNAMIC if ARCH_QCOM
-       select QCOM_MDT_LOADER if ARCH_QCOM
+       select QCOM_MDT_LOADER
        select QCOM_SCM
        select VIDEOBUF2_DMA_CONTIG
        select V4L2_MEM2MEM_DEV