]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ARM: OMAP2+: Fix an IS_ERR() vs NULL check in _get_pwrdm()
authorJing Xiangfeng <jingxiangfeng@huawei.com>
Fri, 24 Jul 2020 03:54:30 +0000 (11:54 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 17 Sep 2020 11:55:24 +0000 (13:55 +0200)
[ Upstream commit a58cfdba2039ff2d5758840e97a23a2dedecf1e8 ]

The of_clk_get() function returns error pointers, it never returns NULL.

Fixes: 4ea3711aece4 ("ARM: OMAP2+: omap-iommu.c conversion to ti-sysc")
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/arm/mach-omap2/omap-iommu.c

index 54aff33e55e6efac5de04ce915967ee77c9c412b..bfa5e1b8dba7f86a63cbe26ef01161250d1c4b8a 100644 (file)
@@ -74,7 +74,7 @@ static struct powerdomain *_get_pwrdm(struct device *dev)
                return pwrdm;
 
        clk = of_clk_get(dev->of_node->parent, 0);
-       if (!clk) {
+       if (IS_ERR(clk)) {
                dev_err(dev, "no fck found\n");
                return NULL;
        }