]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
[3.12] gh-128605: Add branch protections for x86_64 in asm_trampolineS (#128606)...
authorstratakis <cstratak@redhat.com>
Thu, 10 Jul 2025 10:22:14 +0000 (12:22 +0200)
committerGitHub <noreply@github.com>
Thu, 10 Jul 2025 10:22:14 +0000 (11:22 +0100)
[3.12] gh-128605: Add branch protections for x86_64 in asm_trampoline.S (#128606)

Apply Intel Control-flow Technology for x86-64 on asm_trampoline.S.

Required for mitigation against return-oriented programming (ROP)
and Call or Jump Oriented Programming (COP/JOP) attacks.

Manual application is required for the assembly files.

See also: https://sourceware.org/annobin/annobin.html/Test-cf-protection.html

Python/asm_trampoline.S

index 460707717df0032b2f2bdaa7c50a6cb464caa591..341d0bbe51f344f930952d2dd226b09e34ae2deb 100644 (file)
@@ -9,6 +9,9 @@
 # }
 _Py_trampoline_func_start:
 #ifdef __x86_64__
+#if defined(__CET__) && (__CET__ & 1)
+    endbr64
+#endif
     sub    $8, %rsp
     call    *%rcx
     add    $8, %rsp
@@ -26,3 +29,22 @@ _Py_trampoline_func_start:
     .globl     _Py_trampoline_func_end
 _Py_trampoline_func_end:
     .section        .note.GNU-stack,"",@progbits
+# Note for indicating the assembly code supports CET
+#if defined(__x86_64__) && defined(__CET__) && (__CET__ & 1)
+    .section    .note.gnu.property,"a"
+    .align 8
+    .long    1f - 0f
+    .long    4f - 1f
+    .long    5
+0:
+    .string  "GNU"
+1:
+    .align 8
+    .long    0xc0000002
+    .long    3f - 2f
+2:
+    .long    0x3
+3:
+    .align 8
+4:
+#endif // __x86_64__