Close fds on pipe() error in tor_spawn_background().

diff --git a/changes/bug4296 b/changes/bug4296
new file mode 100644 (file)
index 0000000..c265094
--- /dev/null
+++ b/changes/bug4296
@@ -0,0 +1,3 @@
+  o Minor bugfixes:
+    - On a failed pipe() call, don't leak fds. Fix for bug 4296; bugfix
+      on 0.2.3.1-alpha.

diff --git a/src/common/util.c b/src/common/util.c
index 3950fc169596710fb5a5c3a1250ee55db136adcf..1807ee7adc013e1ef2bfa53d8a1c59f85147f45e 100644 (file)
--- a/src/common/util.c
+++ b/src/common/util.c
@@ -3470,6 +3470,10 @@ tor_spawn_background(const char *const filename, const char **argv,
     log_warn(LD_GENERAL,
       "Failed to set up pipe for stderr communication with child process: %s",
       strerror(errno));
+
+    close(stdout_pipe[0]);
+    close(stdout_pipe[1]);
+
     return status;
   }