]> git.ipfire.org Git - thirdparty/rsync.git/commitdiff
ci: build test helpers before the valgrind run
authorAndrew Tridgell <andrew@tridgell.net>
Sat, 13 Jun 2026 07:24:18 +0000 (17:24 +1000)
committerAndrew Tridgell <andrew@tridgell.net>
Sat, 13 Jun 2026 08:56:32 +0000 (18:56 +1000)
`make` alone does not build the CHECK_PROGS test helpers (tls, trimslash,
t_chmod_secure, ...), so runtests.py exited immediately with "missing
test helper program(s)", produced no valgrind logs, and the scan step
failed every job with "the suite did not run". Use `make check-progs`,
which builds rsync plus the helpers and symlink fixtures without running
the suite.

.github/workflows/valgrind.yml

index 036581c83d98d9e697abcc1033d8a9347495987c..c1ffaebc4151b945f41f0d568f80cb9c4ae945e2 100644 (file)
@@ -38,7 +38,7 @@ jobs:
     - name: configure
       run: ./configure --with-rrsync --enable-debug
     - name: make
-      run: make
+      run: make check-progs   # builds rsync + the test helper programs runtests.py needs
     - name: info
       run: ./rsync --version