]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/msm/dpu: Add a null ptr check for dpu_encoder_needs_modeset
authorChenyuan Yang <chenyuan0y@gmail.com>
Tue, 22 Jul 2025 21:17:40 +0000 (16:17 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 4 Sep 2025 14:55:37 +0000 (16:55 +0200)
[ Upstream commit abebfed208515726760d79cf4f9f1a76b9a10a84 ]

The drm_atomic_get_new_connector_state() can return NULL if the
connector is not part of the atomic state. Add a check to prevent
a NULL pointer dereference.

This follows the same pattern used in dpu_encoder_update_topology()
within the same file, which checks for NULL before using conn_state.

Signed-off-by: Chenyuan Yang <chenyuan0y@gmail.com>
Fixes: 1ce69c265a53 ("drm/msm/dpu: move resource allocation to CRTC")
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patchwork: https://patchwork.freedesktop.org/patch/665188/
Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c

index c0ed110a7d30fa1282676e3ae4c9f1316a3a3bf1..4bddb9504796b6a6c2cd74d6f7dc8a0ed4e8046e 100644 (file)
@@ -729,6 +729,8 @@ bool dpu_encoder_needs_modeset(struct drm_encoder *drm_enc, struct drm_atomic_st
                return false;
 
        conn_state = drm_atomic_get_new_connector_state(state, connector);
+       if (!conn_state)
+               return false;
 
        /**
         * These checks are duplicated from dpu_encoder_update_topology() since