]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4:auth: Fix ‘user_info_dc_out’ leak
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Thu, 21 Sep 2023 02:21:55 +0000 (14:21 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Wed, 27 Sep 2023 02:43:28 +0000 (02:43 +0000)
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/auth/kerberos/kerberos_pac.c

index 46b9b235854ecc31264f987fcbcf36433f4868ec..4f291d81064193320f2467cea1ca3c6e14737cd3 100644 (file)
@@ -392,7 +392,7 @@ krb5_error_code kerberos_pac_to_user_info_dc(TALLOC_CTX *mem_ctx,
        }
 
        /* Pull this right into the normal auth system structures */
-       nt_status = make_user_info_dc_pac(mem_ctx,
+       nt_status = make_user_info_dc_pac(tmp_ctx,
                                         info.logon_info.info,
                                         upn_dns_info,
                                         group_inclusion,
@@ -492,7 +492,7 @@ krb5_error_code kerberos_pac_to_user_info_dc(TALLOC_CTX *mem_ctx,
                };
        }
 
-       *user_info_dc = user_info_dc_out;
+       *user_info_dc = talloc_steal(mem_ctx, user_info_dc_out);
        if (resource_groups_out != NULL) {
                *resource_groups = talloc_steal(mem_ctx, resource_groups_out);
        }