shared/bus-util: move bus_message_read_id128() to bus-message-util

diff --git a/src/core/dbus-manager.c b/src/core/dbus-manager.c
index 99e3ea12ac5f82efb40a14b9f973f9cea856cb90..4b61002eac853abdfa4b106e2864f1d8494d54e6 100644 (file)
--- a/src/core/dbus-manager.c
+++ b/src/core/dbus-manager.c
@@ -12,6 +12,7 @@
 #include "bus-common-errors.h"
 #include "bus-get-properties.h"
 #include "bus-log-control-api.h"
+#include "bus-message-util.h"
 #include "bus-util.h"
 #include "chase.h"
 #include "confidential-virt.h"

diff --git a/src/hostname/hostnamectl.c b/src/hostname/hostnamectl.c
index cd4f86af8012013a3455449960935b92fd7bd1f1..2d1334f654c12ae6582352dbb9cfaeb0dbe16fa4 100644 (file)
--- a/src/hostname/hostnamectl.c
+++ b/src/hostname/hostnamectl.c
@@ -18,6 +18,7 @@
 #include "bus-error.h"
 #include "bus-locator.h"
 #include "bus-map-properties.h"
+#include "bus-message-util.h"
 #include "format-table.h"
 #include "hostname-setup.h"
 #include "hostname-util.h"

diff --git a/src/machine/machinectl.c b/src/machine/machinectl.c
index 39d3f3aed82710d42f6111849574e5fda035f1dd..91bef1a5e99406e273eac92f3627ac515fd4ae19 100644 (file)
--- a/src/machine/machinectl.c
+++ b/src/machine/machinectl.c
@@ -21,6 +21,7 @@
 #include "bus-error.h"
 #include "bus-locator.h"
 #include "bus-map-properties.h"
+#include "bus-message-util.h"
 #include "bus-print-properties.h"
 #include "bus-unit-procs.h"
 #include "bus-unit-util.h"

diff --git a/src/machine/machined-dbus.c b/src/machine/machined-dbus.c
index fc50d3f14711065867f0bf045463b032e2c368a9..e50ed7e0dfcada0a2f5f769259972dd03a34aee0 100644 (file)
--- a/src/machine/machined-dbus.c
+++ b/src/machine/machined-dbus.c
@@ -10,6 +10,7 @@
 #include "bus-common-errors.h"
 #include "bus-get-properties.h"
 #include "bus-locator.h"
+#include "bus-message-util.h"
 #include "bus-polkit.h"
 #include "cgroup-util.h"
 #include "discover-image.h"

diff --git a/src/run/run.c b/src/run/run.c
index 28953a6514b925b5f25cb1d2a2338f3baa5533b7..4a7a5d939c10d0b8a080a6f71f49096b5606ed18 100644 (file)
--- a/src/run/run.c
+++ b/src/run/run.c
@@ -15,6 +15,7 @@
 #include "bus-error.h"
 #include "bus-locator.h"
 #include "bus-map-properties.h"
+#include "bus-message-util.h"
 #include "bus-unit-util.h"
 #include "bus-wait-for-jobs.h"
 #include "calendarspec.h"

diff --git a/src/shared/bus-map-properties.c b/src/shared/bus-map-properties.c
index a6cd7528949684f60c42dc00fd02754abd4cced8..18d83c336f5617656c0fd6805e8dc96a1faa54ba 100644 (file)
--- a/src/shared/bus-map-properties.c
+++ b/src/shared/bus-map-properties.c
@@ -5,6 +5,7 @@
 #include "bus-util.h"
 #include "strv.h"
 #include "bus-message.h"
+#include "bus-message-util.h"
 
 int bus_map_id128(sd_bus *bus, const char *member, sd_bus_message *m, sd_bus_error *error, void *userdata) {
         sd_id128_t *p = userdata;

diff --git a/src/shared/bus-message-util.c b/src/shared/bus-message-util.c
index d8c483ef62ba8fa51aeb25f758b8e2129225121c..e93be9b3c5095ce5f89213189c904fc8eb782557 100644 (file)
--- a/src/shared/bus-message-util.c
+++ b/src/shared/bus-message-util.c
@@ -7,6 +7,35 @@
 #include "copy.h"
 #include "resolve-util.h"
 
+int bus_message_read_id128(sd_bus_message *m, sd_id128_t *ret) {
+        const void *a;
+        size_t sz;
+        int r;
+
+        assert(m);
+
+        r = sd_bus_message_read_array(m, 'y', &a, &sz);
+        if (r < 0)
+                return r;
+
+        switch (sz) {
+
+        case 0:
+                if (ret)
+                        *ret = SD_ID128_NULL;
+                return 0;
+
+        case sizeof(sd_id128_t):
+                if (ret)
+                        memcpy(ret, a, sz);
+                return !memeqzero(a, sz); /* This mimics sd_id128_is_null(), but ret may be NULL,
+                                           * and a may be misaligned, so use memeqzero() here. */
+
+        default:
+                return -EINVAL;
+        }
+}
+
 int bus_message_read_ifindex(sd_bus_message *message, sd_bus_error *error, int *ret) {
         int ifindex, r;
 

diff --git a/src/shared/bus-message-util.h b/src/shared/bus-message-util.h
index 50025766c2ee8003229e27fea5aeb9f38c9b47a2..698960561ced8b5a423052195d1121473ee75767 100644 (file)
--- a/src/shared/bus-message-util.h
+++ b/src/shared/bus-message-util.h
@@ -6,6 +6,8 @@
 #include "in-addr-util.h"
 #include "socket-netlink.h"
 
+int bus_message_read_id128(sd_bus_message *m, sd_id128_t *ret);
+
 int bus_message_read_ifindex(sd_bus_message *message, sd_bus_error *error, int *ret);
 int bus_message_read_family(sd_bus_message *message, sd_bus_error *error, int *ret);
 int bus_message_read_in_addr_auto(sd_bus_message *message, sd_bus_error *error, int *ret_family, union in_addr_union *ret_addr);

diff --git a/src/shared/bus-util.c b/src/shared/bus-util.c
index e38433ddc0267003ad3ce6dceae546b250fa7e51..d6189deb1809b153f281e56d44232467833e9f62 100644 (file)
--- a/src/shared/bus-util.c
+++ b/src/shared/bus-util.c
@@ -953,34 +953,6 @@ int bus_query_sender_pidref(
         return bus_creds_get_pidref(creds, ret);
 }
 
-int bus_message_read_id128(sd_bus_message *m, sd_id128_t *ret) {
-        const void *a;
-        size_t sz;
-        int r;
-
-        assert(m);
-
-        r = sd_bus_message_read_array(m, 'y', &a, &sz);
-        if (r < 0)
-                return r;
-
-        switch (sz) {
-        case 0:
-                if (ret)
-                        *ret = SD_ID128_NULL;
-                return 0;
-
-        case sizeof(sd_id128_t):
-                if (ret)
-                        memcpy(ret, a, sz);
-                return !memeqzero(a, sz); /* This mimics sd_id128_is_null(), but ret may be NULL,
-                                           * and a may be misaligned, so use memeqzero() here. */
-
-        default:
-                return -EINVAL;
-        }
-}
-
 static const char* const bus_transport_table[] = {
         [BUS_TRANSPORT_LOCAL]   = "local",
         [BUS_TRANSPORT_REMOTE]  = "remote",

diff --git a/src/shared/bus-util.h b/src/shared/bus-util.h
index 95b9adb7b1b1435f23375f4479cda532cab4d3cb..b08635fd36662aca60ff5b9ef40a27c1928f56a7 100644 (file)
--- a/src/shared/bus-util.h
+++ b/src/shared/bus-util.h
@@ -87,6 +87,4 @@ int bus_property_get_string_set(sd_bus *bus, const char *path, const char *inter
 int bus_creds_get_pidref(sd_bus_creds *c, PidRef *ret);
 int bus_query_sender_pidref(sd_bus_message *m, PidRef *ret);
 
-int bus_message_read_id128(sd_bus_message *m, sd_id128_t *ret);
-
 const char* bus_transport_to_string(BusTransport transport) _const_;