]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
usb: chipidea: core: refactor ci_usb_role_switch_set()
authorXu Yang <xu.yang_2@nxp.com>
Thu, 2 Apr 2026 07:14:55 +0000 (15:14 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 7 Apr 2026 11:46:54 +0000 (13:46 +0200)
Current code is redundant, refactor the code, no function change.

Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
Link: https://patch.msgid.link/20260402071457.2516021-1-xu.yang_2@nxp.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/chipidea/core.c

index fac11f20cf0ac263c21d654b6acadb756b1dd2dc..87be716dff3e4149ce3eef03043c6865330d5f79 100644 (file)
@@ -618,28 +618,13 @@ static int ci_usb_role_switch_set(struct usb_role_switch *sw,
        struct ci_hdrc *ci = usb_role_switch_get_drvdata(sw);
        struct ci_hdrc_cable *cable;
 
-       if (role == USB_ROLE_HOST) {
-               cable = &ci->platdata->id_extcon;
-               cable->changed = true;
-               cable->connected = true;
-               cable = &ci->platdata->vbus_extcon;
-               cable->changed = true;
-               cable->connected = false;
-       } else if (role == USB_ROLE_DEVICE) {
-               cable = &ci->platdata->id_extcon;
-               cable->changed = true;
-               cable->connected = false;
-               cable = &ci->platdata->vbus_extcon;
-               cable->changed = true;
-               cable->connected = true;
-       } else {
-               cable = &ci->platdata->id_extcon;
-               cable->changed = true;
-               cable->connected = false;
-               cable = &ci->platdata->vbus_extcon;
-               cable->changed = true;
-               cable->connected = false;
-       }
+       cable = &ci->platdata->id_extcon;
+       cable->changed = true;
+       cable->connected = (role == USB_ROLE_HOST);
+
+       cable = &ci->platdata->vbus_extcon;
+       cable->changed = true;
+       cable->connected = (role == USB_ROLE_DEVICE);
 
        ci_irq(ci);
        return 0;