t-reftable-record: add comparison tests for obj records

In the current testing setup for obj records, the comparison
functions for obj records, reftable_obj_record_cmp_void() and
reftable_obj_record_equal_void() are left untested.

Add tests for the same by using the wrapper functions
reftable_record_cmp() and reftable_record_equal() for
reftable_index_record_cmp_void() and reftable_index_record_equal_void()
respectively.

Mentored-by: Patrick Steinhardt <ps@pks.im>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com>
Acked-by: Karthik Nayak <karthik.188@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/unit-tests/t-reftable-record.c b/t/unit-tests/t-reftable-record.c
index e8db337eb82f2b7132773cec5e5f9cf3a6a8a505..46614de948147e2bfeaafff4bf111965513a9163 100644 (file)
--- a/t/unit-tests/t-reftable-record.c
+++ b/t/unit-tests/t-reftable-record.c
@@ -299,6 +299,44 @@ static void t_key_roundtrip(void)
        strbuf_release(&roundtrip);
 }
 
+static void t_reftable_obj_record_comparison(void)
+{
+
+       uint8_t id_bytes[] = { 0, 1, 2, 3, 4, 5, 6 };
+       uint64_t offsets[] = { 0, 16, 32, 48, 64, 80, 96, 112};
+       struct reftable_record in[3] = {
+               {
+                       .type = BLOCK_TYPE_OBJ,
+                       .u.obj.hash_prefix = id_bytes,
+                       .u.obj.hash_prefix_len = 7,
+                       .u.obj.offsets = offsets,
+                       .u.obj.offset_len = 8,
+               },
+               {
+                       .type = BLOCK_TYPE_OBJ,
+                       .u.obj.hash_prefix = id_bytes,
+                       .u.obj.hash_prefix_len = 7,
+                       .u.obj.offsets = offsets,
+                       .u.obj.offset_len = 5,
+               },
+               {
+                       .type = BLOCK_TYPE_OBJ,
+                       .u.obj.hash_prefix = id_bytes,
+                       .u.obj.hash_prefix_len = 5,
+               },
+       };
+
+       check(!reftable_record_equal(&in[0], &in[1], GIT_SHA1_RAWSZ));
+       check(!reftable_record_cmp(&in[0], &in[1]));
+
+       check(!reftable_record_equal(&in[1], &in[2], GIT_SHA1_RAWSZ));
+       check_int(reftable_record_cmp(&in[1], &in[2]), >, 0);
+
+       in[1].u.obj.offset_len = in[0].u.obj.offset_len;
+       check(reftable_record_equal(&in[0], &in[1], GIT_SHA1_RAWSZ));
+       check(!reftable_record_cmp(&in[0], &in[1]));
+}
+
 static void t_reftable_obj_record_roundtrip(void)
 {
        uint8_t testHash1[GIT_SHA1_RAWSZ] = { 1, 2, 3, 4, 0 };
@@ -443,6 +481,7 @@ int cmd_main(int argc, const char *argv[])
        TEST(t_reftable_ref_record_comparison(), "comparison operations work on ref record");
        TEST(t_reftable_log_record_comparison(), "comparison operations work on log record");
        TEST(t_reftable_index_record_comparison(), "comparison operations work on index record");
+       TEST(t_reftable_obj_record_comparison(), "comparison operations work on obj record");
        TEST(t_reftable_log_record_roundtrip(), "record operations work on log record");
        TEST(t_reftable_ref_record_roundtrip(), "record operations work on ref record");
        TEST(t_varint_roundtrip(), "put_var_int and get_var_int work");