ALSA: hda/realtek: Add inverted LED quirk for HP ZBook 8 G2a

HP ZBook 8 G2a 14 and 16 (SSIDs 0x103c:0x8f94, 0x103c:0x8f95) use the
Realtek ALC245 codec with a TAS2781 amplifier via I2C. They share the same
hardware configuration as the existing 0x8f40/0x8f41/0x8f42/0x8f62 models
but have inverted speaker mute LED polarity, so the existing
ALC245_FIXUP_HP_TAS2781_I2C_MUTE_LED quirk drives the LED backwards: off
when muted and on when unmuted.

Add a dedicated quirk with inverted COEF values. These are speaker-only
models without an HP pin, so the LED is driven directly through the
vmaster_mute hook; there is no need to probe the HP pin at runtime since
the configuration is static and known per SSID.

Signed-off-by: Chris Chiu <chris.chiu@canonical.com>
Link: https://patch.msgid.link/20260716023825.387532-1-chris.chiu@canonical.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index e3958310af894d6897ee240d8e344db8dcb0cd06..92feb2df000793d843e88d746884297d717d7c34 100644 (file)
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -3773,6 +3773,15 @@ static void alc245_hp_spk_mute_led_update(void *private_data, int enabled)
        alc_update_coef_idx(codec, 0x0b, 0x0c, val);
 }
 
+static void alc245_hp_spk_mute_led_update_inverted(void *private_data, int enabled)
+{
+       struct hda_codec *codec = private_data;
+       unsigned int val;
+
+       val = enabled ? 0x04 : 0x08; /* inverted: 0x04 led off, 0x08 led on */
+       alc_update_coef_idx(codec, 0x0b, 0x0c, val);
+}
+
 /* JD2: mute led GPIO3: micmute led */
 static void alc245_tas2781_i2c_hp_fixup_muteled(struct hda_codec *codec,
                                          const struct hda_fixup *fix, int action)
@@ -3801,6 +3810,33 @@ static void alc245_tas2781_i2c_hp_fixup_muteled(struct hda_codec *codec,
                alc245_fixup_hp_mute_led_coefbit(codec, fix, action);
        alc285_fixup_hp_coef_micmute_led(codec, fix, action);
 }
+
+/* Same as alc245_tas2781_i2c_hp_fixup_muteled(), but with inverted speaker
+ * mute LED polarity. The HP ZBook 8 G2a 14/16 (0x103c:0x8f94, 0x103c:0x8f95)
+ * are speaker-only models without an HP pin, so the LED is driven directly
+ * through the vmaster_mute hook.
+ */
+static void alc245_tas2781_i2c_hp_fixup_muteled_inverted(struct hda_codec *codec,
+                                       const struct hda_fixup *fix, int action)
+{
+       struct alc_spec *spec = codec->spec;
+       static const hda_nid_t conn[] = { 0x02 };
+
+       switch (action) {
+       case HDA_FIXUP_ACT_PRE_PROBE:
+               spec->gen.vmaster_mute.hook = alc245_hp_spk_mute_led_update_inverted;
+               spec->gen.vmaster_mute_led = 1;
+               spec->gen.auto_mute_via_amp = 1;
+               snd_hda_override_conn_list(codec, 0x17, ARRAY_SIZE(conn), conn);
+               break;
+       case HDA_FIXUP_ACT_INIT:
+               alc245_hp_spk_mute_led_update_inverted(codec, !spec->gen.master_mute);
+               break;
+       }
+
+       tas2781_fixup_txnw_i2c(codec, fix, action);
+       alc285_fixup_hp_coef_micmute_led(codec, fix, action);
+}
 /*
  * Clear COEF 0x0d (PCBEEP passthrough) bit 0x40 where BIOS sets it wrongly
  * at PM resume
@@ -4163,6 +4199,7 @@ enum {
        ALC256_FIXUP_VAIO_RPL_MIC_NO_PRESENCE,
        ALC245_FIXUP_HP_TAS2781_SPI_MUTE_LED,
        ALC245_FIXUP_HP_TAS2781_I2C_MUTE_LED,
+       ALC245_FIXUP_HP_TAS2781_I2C_MUTE_LED_INVERTED,
        ALC288_FIXUP_SURFACE_SWAP_DACS,
        ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO,
        ALC233_FIXUP_LENOVO_GPIO2_MIC_HOTKEY,
@@ -6734,6 +6771,10 @@ static const struct hda_fixup alc269_fixups[] = {
                .type = HDA_FIXUP_FUNC,
                .v.func = alc245_tas2781_i2c_hp_fixup_muteled,
        },
+       [ALC245_FIXUP_HP_TAS2781_I2C_MUTE_LED_INVERTED] = {
+               .type = HDA_FIXUP_FUNC,
+               .v.func = alc245_tas2781_i2c_hp_fixup_muteled_inverted,
+       },
        [ALC288_FIXUP_SURFACE_SWAP_DACS] = {
                .type = HDA_FIXUP_FUNC,
                .v.func = alc288_fixup_surface_swap_dacs,
@@ -7384,6 +7425,8 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
        SND_PCI_QUIRK(0x103c, 0x8f42, "HP ZBook 8 G2a 14W", ALC245_FIXUP_HP_TAS2781_I2C_MUTE_LED),
        SND_PCI_QUIRK(0x103c, 0x8f57, "HP Trekker G7JC", ALC287_FIXUP_CS35L41_I2C_2),
        SND_PCI_QUIRK(0x103c, 0x8f62, "HP ZBook 8 G2a 16W", ALC245_FIXUP_HP_TAS2781_I2C_MUTE_LED),
+       SND_PCI_QUIRK(0x103c, 0x8f94, "HP ZBook 8 G2a 14", ALC245_FIXUP_HP_TAS2781_I2C_MUTE_LED_INVERTED),
+       SND_PCI_QUIRK(0x103c, 0x8f95, "HP ZBook 8 G2a 16", ALC245_FIXUP_HP_TAS2781_I2C_MUTE_LED_INVERTED),
        SND_PCI_QUIRK(0x1043, 0x1024, "ASUS Zephyrus G14 2025", ALC285_FIXUP_ASUS_GA403U_HEADSET_MIC),
        SND_PCI_QUIRK(0x1043, 0x1032, "ASUS VivoBook X513EA", ALC256_FIXUP_ASUS_MIC_NO_PRESENCE),
        SND_PCI_QUIRK(0x1043, 0x1034, "ASUS GU605C", ALC285_FIXUP_ASUS_GU605_SPI_SPEAKER2_TO_DAC1),