]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
ctdb-tests: Clean up argument validation in 00.test event script
authorMartin Schwenke <martin@meltin.net>
Mon, 11 Jun 2018 19:54:07 +0000 (05:54 +1000)
committerMartin Schwenke <martins@samba.org>
Mon, 2 Jul 2018 06:51:21 +0000 (08:51 +0200)
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb/tests/simple/etc-ctdb/events/legacy/00.test.script

index 71b2e05a6af7ffbc5834a3c8cc298ccb138e87ff..28141b2b747fb6234377493f057efef27849d92c 100755 (executable)
@@ -1,10 +1,14 @@
 #!/bin/sh
 # event script for 'make test'
 
-cmd="$1"
+. "${CTDB_BASE}/functions"
+
+ctdb_check_args "$@"
+
+event="$1"
 shift
 
-case $cmd in 
+case "$event" in
     monitor)
        echo "monitor event"
        echo "monitor event stderr" >&2
@@ -35,10 +39,6 @@ case $cmd in
        ;;
        
      takeip)
-       if [ $# != 3 ]; then
-          echo "must supply interface, IP and maskbits"
-          exit 1
-       fi
        iface=$1
        ip=$2
        maskbits=$3
@@ -57,10 +57,6 @@ case $cmd in
      ##################################################
      # called when ctdbd wants to release an IP address
      releaseip)
-       if [ $# != 3 ]; then
-          echo "must supply interface, IP and maskbits"
-          exit 1
-       fi
        iface=$1
        ip=$2
        maskbits=$3