drm/bridge/analogix/anx6345: Don't link encoder until after connector registration

Another case of linking an encoder to a connector after the connector's
been registered. The proper place to do this is before connector
registration, so let's fix that.

Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210219215326.2227596-12-lyude@redhat.com

diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
index 8e016ba7c54afeedfa67c6fd9b9340ff65349f95..6258f16da0e88847907ef0da2285d6909b99c8c4 100644 (file)
--- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
@@ -556,12 +556,6 @@ static int anx6345_bridge_attach(struct drm_bridge *bridge,
        drm_connector_helper_add(&anx6345->connector,
                                 &anx6345_connector_helper_funcs);
 
-       err = drm_connector_register(&anx6345->connector);
-       if (err) {
-               DRM_ERROR("Failed to register connector: %d\n", err);
-               return err;
-       }
-
        anx6345->connector.polled = DRM_CONNECTOR_POLL_HPD;
 
        err = drm_connector_attach_encoder(&anx6345->connector,
@@ -571,6 +565,12 @@ static int anx6345_bridge_attach(struct drm_bridge *bridge,
                return err;
        }
 
+       err = drm_connector_register(&anx6345->connector);
+       if (err) {
+               DRM_ERROR("Failed to register connector: %d\n", err);
+               return err;
+       }
+
        return 0;
 }