btrfs: sysfs: validate scrub_speed_max value

commit 2b0122aaa800b021e36027d7f29e206f87c761d6 upstream.

The value set as scrub_speed_max accepts size with suffixes
(k/m/g/t/p/e) but we should still validate it for trailing characters,
similar to what we do with chunk_size_store.

CC: stable@vger.kernel.org # 5.15+
Signed-off-by: David Disseldorp <ddiss@suse.de>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c
index 1c40e51513210e8538c428223314b86a161fa0ab..899dda6eb8353044cd6c59d27cd7c15fb7d5bc6e 100644 (file)
--- a/fs/btrfs/sysfs.c
+++ b/fs/btrfs/sysfs.c
@@ -1523,6 +1523,10 @@ static ssize_t btrfs_devinfo_scrub_speed_max_store(struct kobject *kobj,
        unsigned long long limit;
 
        limit = memparse(buf, &endptr);
+       /* There could be trailing '\n', also catch any typos after the value. */
+       endptr = skip_spaces(endptr);
+       if (*endptr != 0)
+               return -EINVAL;
        WRITE_ONCE(device->scrub_speed_max, limit);
        return len;
 }