]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
Fix Memory leak in app_passwd
authorhuanghuihui0904 <625173@qq.com>
Mon, 9 Mar 2026 14:57:00 +0000 (22:57 +0800)
committerNeil Horman <nhorman@openssl.org>
Tue, 10 Mar 2026 17:42:27 +0000 (13:42 -0400)
Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Paul Yang <paulyang.inf@gmail.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
MergeDate: Tue Mar 10 17:42:48 2026
(Merged from https://github.com/openssl/openssl/pull/30325)

apps/lib/apps.c

index 9d81264d447d8aee0b576b65dfc6d20ca1037aa9..53dbcf2c2de52c2a65ecd6b5052d94af126b39ab 100644 (file)
@@ -186,8 +186,11 @@ int app_passwd(const char *arg1, const char *arg2, char **pass1, char **pass2)
     }
     if (arg2 != NULL) {
         *pass2 = app_get_pass(arg2, same ? 2 : 0);
-        if (*pass2 == NULL)
+        if (*pass2 == NULL) {
+            clear_free(*pass1);
+            *pass1 = NULL;
             return 0;
+        }
     } else if (pass2 != NULL) {
         *pass2 = NULL;
     }