]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
lib/util/charset: clang: Fix Value stored to 'reason' is never read warning
authorNoel Power <noel.power@suse.com>
Fri, 24 May 2019 13:37:00 +0000 (13:37 +0000)
committerNoel Power <npower@samba.org>
Tue, 11 Jun 2019 12:10:17 +0000 (12:10 +0000)
Fixes:

lib/util/charset/convert_string.c:301:5: warning: Value stored to 'reason' is never read <--[clang]

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer gary@catalyst.net.nz
lib/util/charset/convert_string.c

index d8fb9bdd477bbff2a8cb475d992a5e8333832bc1..d274e305a0c6797e810378d70b13def2f026d8b7 100644 (file)
@@ -300,13 +300,13 @@ bool convert_string_handle(struct smb_iconv_handle *ic,
                        {
                                reason="No more room";
                                if (from == CH_UNIX) {
-                                       DEBUG(3,("E2BIG: convert_string(%s,%s): srclen=%u destlen=%u - '%s'\n",
+                                       DEBUG(3,("E2BIG: convert_string(%s,%s): srclen=%u destlen=%u - '%s' error: %s\n",
                                                 charset_name(ic, from), charset_name(ic, to),
-                                                (unsigned int)srclen, (unsigned int)destlen, (const char *)src));
+                                                (unsigned int)srclen, (unsigned int)destlen, (const char *)src, reason));
                                } else {
-                                       DEBUG(3,("E2BIG: convert_string(%s,%s): srclen=%u destlen=%u\n",
+                                       DEBUG(3,("E2BIG: convert_string(%s,%s): srclen=%u destlen=%u error: %s\n",
                                                 charset_name(ic, from), charset_name(ic, to),
-                                                (unsigned int)srclen, (unsigned int)destlen));
+                                                (unsigned int)srclen, (unsigned int)destlen, reason));
                                }
                                break;
                        }