templates: Avoid recursive call

We had registered an event handler on a checkbox in table header which
would call a function, 'checkboxes', on all checkboxes within that
table. This function, in turn, causes does its work and then triggers
event handlers for all modified checkboxes which include the original
table header checkbox. This resulted in the original event calling
itself recursively.

Resolve this by only modifying the checkboxes in the table body.

Signed-off-by: Stephen Finucane <stephen@that.guru>
Fixes: 44fe7bae ("js: Allow shift-select of checkboxes")

diff --git a/patchwork/templates/patchwork/partials/patch-list.html b/patchwork/templates/patchwork/partials/patch-list.html
index 53d577de306032954b1fc02730d96d9a2dafc47c..2abb9ec2d019564b6bc05fa52adfb867a229a6b0 100644 (file)
--- a/patchwork/templates/patchwork/partials/patch-list.html
+++ b/patchwork/templates/patchwork/partials/patch-list.html
@@ -41,9 +41,9 @@ $(document).ready(function() {
 
     $('#check-all').change(function(e) {
         if(this.checked) {
-            $('#patchlist').checkboxes('check');
+            $('#patchlist > tbody').checkboxes('check');
         } else {
-            $('#patchlist').checkboxes('uncheck');
+            $('#patchlist > tbody').checkboxes('uncheck');
         }
         e.preventDefault();
     });