Remove overzealous _bt_killitems assertion.

An assertion in _bt_killitems expected the scan's currPos state to
contain a valid LSN, saved from when currPos's page was initially read.
The assertion failed to account for the fact that even logged relations
can have leaf pages with an invalid LSN when built with wal_level set to
"minimal".  Remove the faulty assertion.

Oversight in commit e6eed40e (though note that the assertion was
backpatched to stable branches before 18 by commit 7c319f54).

Author: Peter Geoghegan <pg@bowt.ie>
Reported-By: Matthijs van der Vleuten <postgresql@zr40.nl>
Bug: #19082
Discussion: https://postgr.es/m/19082-628e62160dbbc1c1@postgresql.org
Backpatch-through: 13

diff --git a/src/backend/access/nbtree/nbtutils.c b/src/backend/access/nbtree/nbtutils.c
index a448a5470822d2771d9436c3439bab8467eb3174..c733959722b40df2e39c41c3b4cee74d352c6634 100644 (file)
--- a/src/backend/access/nbtree/nbtutils.c
+++ b/src/backend/access/nbtree/nbtutils.c
@@ -4210,7 +4210,6 @@ _bt_killitems(IndexScanDesc scan)
                buf = _bt_getbuf(scan->indexRelation, so->currPos.currPage, BT_READ);
 
                latestlsn = BufferGetLSNAtomic(buf);
-               Assert(!XLogRecPtrIsInvalid(so->currPos.lsn));
                Assert(so->currPos.lsn <= latestlsn);
                if (so->currPos.lsn != latestlsn)
                {