]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4:torture: Initialize union smb_open
authorAndreas Schneider <asn@samba.org>
Fri, 5 Jul 2024 11:58:53 +0000 (13:58 +0200)
committerGünther Deschner <gd@samba.org>
Tue, 16 Jul 2024 11:41:33 +0000 (11:41 +0000)
"Error: UNINIT (CWE-457):
samba-4.20.0rc2/source4/torture/raw/open.c:1136: var_decl: Declaring variable ""io1"" without initializer.
samba-4.20.0rc2/source4/torture/raw/open.c:1198: uninit_use_in_call: Using uninitialized value ""io1.ntcreatex.out.file.fnum"" when calling ""smbcli_close"".
 1196|    done:
 1197|    smbcli_close(cli->tree, io.ntcreatex.out.file.fnum);
 1198|->  smbcli_close(cli->tree, io1.ntcreatex.out.file.fnum);
 1199|    smbcli_deltree(cli->tree, BASEDIR);
 1200|    return ret;"

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
source4/torture/raw/open.c

index 446a284d51010b1d2c6eeb5a36eb43dfa48d0022..f4eeb4e8c6e4af8495b282018a8f8e8378ed1fc9 100644 (file)
@@ -1133,7 +1133,7 @@ done:
 */
 static bool test_ntcreatex_brlocked(struct torture_context *tctx, struct smbcli_state *cli)
 {
-       union smb_open io, io1;
+       union smb_open io = {}, io1 = {};
        union smb_lock io2;
        struct smb_lock_entry lock[1];
        const char *fname = BASEDIR "\\torture_ntcreatex.txt";