]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
[3.13] gh-132542: Set native thread ID after fork (GH-132701) (GH-134361)
authorNoam Cohen <noam@noam.me>
Tue, 20 May 2025 17:03:19 +0000 (20:03 +0300)
committerGitHub <noreply@github.com>
Tue, 20 May 2025 17:03:19 +0000 (17:03 +0000)
(cherry picked from commit 6b735023132a4ac9dc5b849d982104eeb1e8bdad)

Lib/test/test_threading.py
Lib/threading.py
Misc/NEWS.d/next/Core_and_Builtins/2025-04-19-17-16-46.gh-issue-132542.7T_TY_.rst [new file with mode: 0644]

index 51e3f4a66510c91f0e3c60fa4af816a49252a59d..31b52e14e5060fb67c64068c7933814dc80fdaf9 100644 (file)
@@ -1208,6 +1208,34 @@ class ThreadTests(BaseTestCase):
         self.assertEqual(err, b'')
 
 
+    @skip_unless_reliable_fork
+    def test_native_id_after_fork(self):
+        script = """if True:
+            import threading
+            import os
+            from test import support
+
+            parent_thread_native_id = threading.current_thread().native_id
+            print(parent_thread_native_id, flush=True)
+            assert parent_thread_native_id == threading.get_native_id()
+            childpid = os.fork()
+            if childpid == 0:
+                print(threading.current_thread().native_id, flush=True)
+                assert threading.current_thread().native_id == threading.get_native_id()
+            else:
+                try:
+                    assert parent_thread_native_id == threading.current_thread().native_id
+                    assert parent_thread_native_id == threading.get_native_id()
+                finally:
+                    support.wait_process(childpid, exitcode=0)
+            """
+        rc, out, err = assert_python_ok('-c', script)
+        self.assertEqual(rc, 0)
+        self.assertEqual(err, b"")
+        native_ids = out.strip().splitlines()
+        self.assertEqual(len(native_ids), 2)
+        self.assertNotEqual(native_ids[0], native_ids[1])
+
 class ThreadJoinOnShutdown(BaseTestCase):
 
     def _run_and_join(self, script):
index d6b0e2b4fbf1610ddfa3eceba52cddf587b5d0f5..11f1b5af6ac1b35841b213d9604c7747c135d4aa 100644 (file)
@@ -932,6 +932,8 @@ class Thread:
             # This thread is alive.
             self._ident = new_ident
             assert self._handle.ident == new_ident
+            if _HAVE_THREAD_NATIVE_ID:
+                self._set_native_id()
         else:
             # Otherwise, the thread is dead, Jim.  _PyThread_AfterFork()
             # already marked our handle done.
diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2025-04-19-17-16-46.gh-issue-132542.7T_TY_.rst b/Misc/NEWS.d/next/Core_and_Builtins/2025-04-19-17-16-46.gh-issue-132542.7T_TY_.rst
new file mode 100644 (file)
index 0000000..c69ce5e
--- /dev/null
@@ -0,0 +1,2 @@
+Update :attr:`Thread.native_id <threading.Thread.native_id>` after
+:manpage:`fork(2)` to ensure accuracy. Patch by Noam Cohen.