]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3:utils: Initialize DATA_BLOB blob
authorPavel Filipenský <pfilipensky@samba.org>
Wed, 3 Jul 2024 15:30:51 +0000 (17:30 +0200)
committerVolker Lendecke <vl@samba.org>
Fri, 5 Jul 2024 07:45:31 +0000 (07:45 +0000)
Error: UNINIT (CWE-457):
samba-4.20.0rc2/source3/utils/regedit_dialog.c:1965: var_decl: Declaring variable "blob" without initializer.
samba-4.20.0rc2/source3/utils/regedit_dialog.c:2044: uninit_use_in_call: Using uninitialized value "blob" when calling "reg_val_set".
 2042|
 2043|           if (W_ERROR_IS_OK(rv)) {
 2044|->                 rv = reg_val_set(edit->key, name, edit->type, blob);
 2045|           }
 2046|

Signed-off-by: Pavel Filipenský <pfilipensky@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
source3/utils/regedit_dialog.c

index d1cb45fd8f28d6796ebd856963512fc3bf7a7240..f97bc2ccc763c3831b931b172ae51b803ac8c342 100644 (file)
@@ -1962,7 +1962,7 @@ static bool edit_on_submit(struct dialog *dia, struct dialog_section *section,
 {
        struct edit_req *edit = arg;
        WERROR rv;
-       DATA_BLOB blob;
+       DATA_BLOB blob = {};
        const char *name;
        struct dialog_section *name_section, *data;