]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
re PR go/59506 (net FAILs (timeout) on alpha)
authorIan Lance Taylor <ian@gcc.gnu.org>
Fri, 27 Dec 2013 21:42:26 +0000 (21:42 +0000)
committerIan Lance Taylor <ian@gcc.gnu.org>
Fri, 27 Dec 2013 21:42:26 +0000 (21:42 +0000)
PR go/59506

net: use DialTimeout in TestSelfConnect

Backported from master repository.

This avoids problems with systems that take a long time to
find out nothing is listening, while still testing for the
self-connect misfeature since a self-connect should be fast.
With this we may be able to remove the test for non-Linux
systems.

Tested (on GNU/Linux) by editing selfConnect in
tcpsock_posix.go to always return false and verifying that
TestSelfConnect then fails with and without this change.

Idea from Uros Bizjak.

From-SVN: r206224

libgo/go/net/dial_test.go

index c7ffdd3d9c8f0e10aa7527ec54b9e0beac5e8d1e..973e69dea5d5b6454b0b9057c827ff8a0a246a48 100644 (file)
@@ -147,7 +147,7 @@ func TestSelfConnect(t *testing.T) {
                n = 100
        }
        for i := 0; i < n; i++ {
-               c, err := Dial("tcp", addr)
+               c, err := DialTimeout("tcp", addr, time.Millisecond)
                if err == nil {
                        c.Close()
                        t.Errorf("#%d: Dial %q succeeded", i, addr)