]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pwm: Fix incorrect variable used in error message
authorColin Ian King <colin.i.king@gmail.com>
Tue, 2 Sep 2025 13:03:48 +0000 (14:03 +0100)
committerUwe Kleine-König <ukleinek@kernel.org>
Mon, 15 Sep 2025 09:39:43 +0000 (11:39 +0200)
The dev_err message is reporting the incorrect return value ret_tohw,
it should be reporting the value in ret_fromhw. Fix this by using
ret_fromhw instead of ret_tohw.

Fixes: 6c5126c6406d ("pwm: Provide new consumer API functions for waveforms")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Link: https://lore.kernel.org/r/20250902130348.2630053-1-colin.i.king@gmail.com
Cc: stable@vger.kernel.org
Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>
drivers/pwm/core.c

index 0d66376a83ec350e0c3718959f4d794efd71595a..bff0057d87a42b40cbf6572c44ee16251ca596d9 100644 (file)
@@ -276,7 +276,7 @@ int pwm_round_waveform_might_sleep(struct pwm_device *pwm, struct pwm_waveform *
 
        if (IS_ENABLED(CONFIG_PWM_DEBUG) && ret_fromhw > 0)
                dev_err(&chip->dev, "Unexpected return value from __pwm_round_waveform_fromhw: requested %llu/%llu [+%llu], return value %d\n",
-                       wf_req.duty_length_ns, wf_req.period_length_ns, wf_req.duty_offset_ns, ret_tohw);
+                       wf_req.duty_length_ns, wf_req.period_length_ns, wf_req.duty_offset_ns, ret_fromhw);
 
        if (IS_ENABLED(CONFIG_PWM_DEBUG) &&
            (ret_tohw == 0) != pwm_check_rounding(&wf_req, wf))