replay: stop using `the_repository`

In `create_commit()` we're using `the_repository` even though we already
have a repository passed to use as an argument. Fix this.

Note that we still cannot get rid of `USE_THE_REPOSITORY_VARIABLE`. This
is because we use `DEFAULT_ABBREV and `get_commit_output_encoding()`,
both of which are stored as global variables that can be modified via
the Git configuration.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/replay.c b/replay.c
index 98be33b8545866aa06f70ca4dd90d30e17cea2f6..58fdc20140b528401bc38a45cfb072c4a96f670d 100644 (file)
--- a/replay.c
+++ b/replay.c
@@ -62,7 +62,7 @@ struct commit *replay_create_commit(struct repository *repo,
        obj = parse_object(repo, &ret);
 
 out:
-       repo_unuse_commit_buffer(the_repository, based_on, message);
+       repo_unuse_commit_buffer(repo, based_on, message);
        free_commit_extra_headers(extra);
        free_commit_list(parents);
        strbuf_release(&msg);