s4:torture: Avoid useless strdup in libsmbclient test

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13101

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/source4/torture/libsmbclient/libsmbclient.c b/source4/torture/libsmbclient/libsmbclient.c
index f6cd8102c4d5eb4c5b07d49165c0db78eac1a7ac..16ad35182cddda48e0123c2b23dc6083ff68f543 100644 (file)
--- a/source4/torture/libsmbclient/libsmbclient.c
+++ b/source4/torture/libsmbclient/libsmbclient.c
@@ -38,8 +38,8 @@ bool torture_libsmbclient_init_context(struct torture_context *tctx,
 
        /* yes, libsmbclient API frees the username when freeing the context, so
         * have to pass malloced data here */
-       smbc_setUser(ctx, strdup(cli_credentials_get_username(
-                       popt_get_cmdline_credentials())));
+       smbc_setUser(ctx,
+                    cli_credentials_get_username(popt_get_cmdline_credentials()));
 
        *ctx_p = ctx;