]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ASoC: meson: meson-card-utils: use of_property_present() for DT parsing
authorMartin Blumenstingl <martin.blumenstingl@googlemail.com>
Sat, 19 Apr 2025 21:34:48 +0000 (23:34 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Jun 2025 10:04:11 +0000 (11:04 +0100)
commit 171eb6f71e9e3ba6a7410a1d93f3ac213f39dae2 upstream.

Commit c141ecc3cecd ("of: Warn when of_property_read_bool() is used on
non-boolean properties") added a warning when trying to parse a property
with a value (boolean properties are defined as: absent = false, present
without any value = true). This causes a warning from meson-card-utils.

meson-card-utils needs to know about the existence of the
"audio-routing" and/or "audio-widgets" properties in order to properly
parse them. Switch to of_property_present() in order to silence the
following warning messages during boot:
  OF: /sound: Read of boolean property 'audio-routing' with a value.
  OF: /sound: Read of boolean property 'audio-widgets' with a value.

Fixes: 7864a79f37b5 ("ASoC: meson: add axg sound card support")
Tested-by: Christian Hewitt <christianshewitt@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Link: https://patch.msgid.link/20250419213448.59647-1-martin.blumenstingl@googlemail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/soc/meson/meson-card-utils.c

index 0e2691f011b7bdb55a71dfc808469185486e08f9..150e12037dfe7cc2e746c3a9da0f1206d16eca15 100644 (file)
@@ -245,7 +245,7 @@ static int meson_card_parse_of_optional(struct snd_soc_card *card,
                                                    const char *p))
 {
        /* If property is not provided, don't fail ... */
-       if (!of_property_read_bool(card->dev->of_node, propname))
+       if (!of_property_present(card->dev->of_node, propname))
                return 0;
 
        /* ... but do fail if it is provided and the parsing fails */