drm/sun4i: dw-hdmi: Fix max. frequency for H6

[ Upstream commit 1926a0508d8947cf081280d85ff035300dc71da7 ]

It turns out that reasoning for lowering max. supported frequency is
wrong. Scrambling works just fine. Several now fixed bugs prevented
proper functioning, even with rates lower than 340 MHz. Issues were just
more pronounced with higher frequencies.

Fix that by allowing max. supported frequency in HW and fix the comment.

Fixes: cd9063757a22 ("drm/sun4i: DW HDMI: Lower max. supported rate for H6")
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
Tested-by: Andre Heider <a.heider@gmail.com>
Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20210209175900.7092-6-jernej.skrabec@siol.net
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
index 12fe2419562131b370f838558fdbe19fac794cbc..8f721be26477b03890754cf04852c3fcc455df5b 100644 (file)
--- a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
+++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
@@ -49,11 +49,9 @@ sun8i_dw_hdmi_mode_valid_h6(struct drm_connector *connector,
 {
        /*
         * Controller support maximum of 594 MHz, which correlates to
-        * 4K@60Hz 4:4:4 or RGB. However, for frequencies greater than
-        * 340 MHz scrambling has to be enabled. Because scrambling is
-        * not yet implemented, just limit to 340 MHz for now.
+        * 4K@60Hz 4:4:4 or RGB.
         */
-       if (mode->clock > 340000)
+       if (mode->clock > 594000)
                return MODE_CLOCK_HIGH;
 
        return MODE_OK;