Issue #19437: Fix parse_envlist() of the posix/nt module, don't call

PyMapping_Values() with an exception set, exit immediatly on error.

diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
index 5e5f35520caceda1e44d558513a2088abf4701f8..7e6bdc8879e353ed96effec2003538fae234083b 100644 (file)
--- a/Modules/posixmodule.c
+++ b/Modules/posixmodule.c
@@ -5083,8 +5083,10 @@ parse_envlist(PyObject* env, Py_ssize_t *envc_ptr)
     }
     envc = 0;
     keys = PyMapping_Keys(env);
+    if (!keys)
+        goto error;
     vals = PyMapping_Values(env);
-    if (!keys || !vals)
+    if (!vals)
         goto error;
     if (!PyList_Check(keys) || !PyList_Check(vals)) {
         PyErr_Format(PyExc_TypeError,