[2726] Make some things noncopyable

We don't copy them and the implicit copy constructor would be wrong. So
silence the cppcheck and make sure nobody copies by accident.

diff --git a/src/lib/log/logger_impl.h b/src/lib/log/logger_impl.h
index d8dea26a82e96186bff56470bf2d6818015663cf..60f4c58b43dba4b156e8000a077a4f6469cf5d43 100644 (file)
--- a/src/lib/log/logger_impl.h
+++ b/src/lib/log/logger_impl.h
@@ -23,6 +23,7 @@
 #include <string>
 #include <map>
 #include <utility>
+#include <boost/noncopyable.hpp>
 
 
 // log4cplus logger header file
@@ -61,7 +62,7 @@ namespace log {
 /// b) The idea of debug levels is implemented.  See logger_level.h and
 /// logger_level_impl.h for more details on this.
 
-class LoggerImpl {
+class LoggerImpl : public boost::noncopyable {
 public:
 
     /// \brief Constructor

diff --git a/src/lib/log/logger_manager.h b/src/lib/log/logger_manager.h
index b09383e2c680bb54ea77b31c9404f2a22ffb056c..0c49757677728bfe54d7fe467fd28b83fde4074d 100644 (file)
--- a/src/lib/log/logger_manager.h
+++ b/src/lib/log/logger_manager.h
@@ -19,6 +19,8 @@
 #include <util/threads/sync.h>
 #include <log/logger_specification.h>
 
+#include <boost/noncopyable.hpp>
+
 // Generated if, when updating the logging specification, an unknown
 // destination is encountered.
 class UnknownLoggingDestination : public isc::Exception {
@@ -41,7 +43,7 @@ class LoggerManagerImpl;
 /// To isolate the underlying implementation from basic processing, the
 /// LoggerManager is implemented using the "pimpl" idiom.
 
-class LoggerManager {
+class LoggerManager : public boost::noncopyable {
 public:
     /// \brief Constructor
     LoggerManager();