]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commitdiff
mkfs: don't redefine DIRT for protofiles
authorDarrick J. Wong <djwong@kernel.org>
Mon, 8 Jun 2026 16:58:05 +0000 (09:58 -0700)
committerDarrick J. Wong <djwong@kernel.org>
Thu, 2 Jul 2026 19:38:24 +0000 (12:38 -0700)
Codex noticed that the mkfs Makefile redefines DIRT to point only to the
xfs_protofile script.  This overrides the more expansive definition in
buildrules; we should use LDIRT instead.

Cc: <linux-xfs@vger.kernel.org> # v6.13.0
Fixes: 6aace700b7b82d ("mkfs: add a utility to generate protofiles")
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
mkfs/Makefile

index fb1473324cde7c96cdb5057562b6c62597fa0434..16793bdb1e03e311023d7919e856becb3b850829 100644 (file)
@@ -25,7 +25,7 @@ LLDLIBS += $(LIBXFS) $(LIBXCMD) $(LIBFROG) $(LIBRT) $(LIBBLKID) \
        $(LIBUUID) $(LIBINIH) $(LIBURCU) $(LIBPTHREAD)
 LTDEPENDENCIES += $(LIBXFS) $(LIBXCMD) $(LIBFROG)
 LLDFLAGS = -static-libtool-libs
-DIRT = $(XFS_PROTOFILE)
+LDIRT = $(XFS_PROTOFILE)
 
 default: depend $(LTCOMMAND) $(CFGFILES) $(XFS_PROTOFILE)