]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4:dsdb: Fix unreachable code (CID 1435967)
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Thu, 5 Oct 2023 23:45:55 +0000 (12:45 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Fri, 13 Oct 2023 02:18:31 +0000 (02:18 +0000)
Commit ede668e8e24c86f0836dfa5740e76d8aca1e0824 removed this condition
for some unexplained reason, causing the following code to become
unreachable.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/dsdb/samdb/ldb_modules/partition.c

index a0a6db48789e7f825f4a3c4c9be4538fbdc27f1c..94ff730b4b59b140a0911f11854f54e7846516ab 100644 (file)
@@ -428,7 +428,7 @@ static int partition_copy_all_callback_action(
         * lead to an error
         */
        search_ret = dsdb_module_search_dn(module, ac, &res, dn, NULL, DSDB_FLAG_NEXT_MODULE, req);
-       if (search_ret != LDB_SUCCESS) {
+       if (search_ret != LDB_SUCCESS && search_ret != LDB_ERR_NO_SUCH_OBJECT) {
                return search_ret;
        }