]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
iommufd/selftest: Fix ioctl return value in _test_cmd_trigger_vevents()
authorNicolin Chen <nicolinc@nvidia.com>
Tue, 14 Oct 2025 21:48:46 +0000 (14:48 -0700)
committerJason Gunthorpe <jgg@nvidia.com>
Mon, 20 Oct 2025 23:01:23 +0000 (20:01 -0300)
The ioctl returns 0 upon success, so !0 returning -1 breaks the selftest.

Drop the '!' to fix it.

Fixes: 1d235d849425 ("iommu/selftest: prevent use of uninitialized variable")
Link: https://patch.msgid.link/r/20251014214847.1113759-1-nicolinc@nvidia.com
Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
tools/testing/selftests/iommu/iommufd_utils.h

index 772ca1db6e5971227c210050b7da57ef3af969b6..9f472c20c19052d812da38684fa1c31a584817bb 100644 (file)
@@ -1044,8 +1044,8 @@ static int _test_cmd_trigger_vevents(int fd, __u32 dev_id, __u32 nvevents)
        };
 
        while (nvevents--) {
-               if (!ioctl(fd, _IOMMU_TEST_CMD(IOMMU_TEST_OP_TRIGGER_VEVENT),
-                           &trigger_vevent_cmd))
+               if (ioctl(fd, _IOMMU_TEST_CMD(IOMMU_TEST_OP_TRIGGER_VEVENT),
+                         &trigger_vevent_cmd))
                        return -1;
        }
        return 0;