]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
hwmon: (peci/cputemp) Fix off-by-one in cputemp_is_visible()
authorSanman Pradhan <psanman@juniper.net>
Mon, 23 Mar 2026 00:24:37 +0000 (00:24 +0000)
committerGuenter Roeck <linux@roeck-us.net>
Tue, 24 Mar 2026 14:55:34 +0000 (07:55 -0700)
cputemp_is_visible() validates the channel index against
CPUTEMP_CHANNEL_NUMS, but currently uses '>' instead of '>='.
As a result, channel == CPUTEMP_CHANNEL_NUMS is not rejected even though
valid indices are 0 .. CPUTEMP_CHANNEL_NUMS - 1.

Fix the bounds check by using '>=' so invalid channel indices are
rejected before indexing the core bitmap.

Fixes: bf3608f338e9 ("hwmon: peci: Add cputemp driver")
Cc: stable@vger.kernel.org
Signed-off-by: Sanman Pradhan <psanman@juniper.net>
Link: https://lore.kernel.org/r/20260323002352.93417-3-sanman.pradhan@hpe.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/peci/cputemp.c

index badec53ff4461cf6ed80282204fcce20bdbdbf28..457089c561b401336da65e93adfa39af44db3f08 100644 (file)
@@ -319,7 +319,7 @@ static umode_t cputemp_is_visible(const void *data, enum hwmon_sensor_types type
 {
        const struct peci_cputemp *priv = data;
 
-       if (channel > CPUTEMP_CHANNEL_NUMS)
+       if (channel >= CPUTEMP_CHANNEL_NUMS)
                return 0;
 
        if (channel < channel_core)