]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4:kdc: Use talloc_get_type_abort()
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Fri, 16 Jun 2023 03:02:35 +0000 (15:02 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Sun, 25 Jun 2023 23:29:33 +0000 (23:29 +0000)
We subsequently dereference the result without performing a NULL check.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/kdc/wdc-samba4.c

index 30a469a9f355d9bcd2ba9187f74bdbecbdd234b2..8120efd6af3f771d4966bcef1aa05d6a43c954bb 100644 (file)
@@ -684,7 +684,7 @@ static krb5_error_code samba_wdc_check_client_access(void *priv,
                return ENOMEM;
        }
 
-       kdc_entry = talloc_get_type(client->context, struct samba_kdc_entry);
+       kdc_entry = talloc_get_type_abort(client->context, struct samba_kdc_entry);
        password_change = (kdc_request_get_server(r) && kdc_request_get_server(r)->flags.change_pw);
        workstation = get_netbios_name(tmp_ctx,
                                       kdc_request_get_req(r)->req_body.addresses);