If we fail to create the SIP socket, then return -1 from reload_config() so

that load_module() will return AST_MODULE_LOAD_DECLINE.  Otherwise, the console
will just get spammed with error messages every time chan_sip tries to send a
message.

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@54204 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/channels/chan_sip.c b/channels/chan_sip.c
index 2d491d46a621e23bda50216e32c32bba93351bd6..c565e087bcd3a43a27986870882a250bb4b004fe 100644 (file)
--- a/channels/chan_sip.c
+++ b/channels/chan_sip.c
@@ -16510,6 +16510,7 @@ static int reload_config(enum channelreloadreason reason)
                sipsock = socket(AF_INET, SOCK_DGRAM, 0);
                if (sipsock < 0) {
                        ast_log(LOG_WARNING, "Unable to create SIP socket: %s\n", strerror(errno));
+                       return -1;
                } else {
                        /* Allow SIP clients on the same host to access us: */
                        const int reuseFlag = 1;