]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-111789: Use PyDict_GetItemRef() in Modules/_csv.c (gh-112073)
authorSerhiy Storchaka <storchaka@gmail.com>
Mon, 27 Nov 2023 17:35:52 +0000 (19:35 +0200)
committerGitHub <noreply@github.com>
Mon, 27 Nov 2023 17:35:52 +0000 (18:35 +0100)
Modules/_csv.c

index 714fbef08d22c98a7c5f13015ba00f9ce00060aa..ae6b6457ffad9af22534399e908e8875d1e60ca8 100644 (file)
@@ -160,15 +160,9 @@ static PyObject *
 get_dialect_from_registry(PyObject *name_obj, _csvstate *module_state)
 {
     PyObject *dialect_obj;
-
-    dialect_obj = PyDict_GetItemWithError(module_state->dialects, name_obj);
-    if (dialect_obj == NULL) {
-        if (!PyErr_Occurred())
-            PyErr_Format(module_state->error_obj, "unknown dialect");
+    if (PyDict_GetItemRef(module_state->dialects, name_obj, &dialect_obj) == 0) {
+        PyErr_SetString(module_state->error_obj, "unknown dialect");
     }
-    else
-        Py_INCREF(dialect_obj);
-
     return dialect_obj;
 }