]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: dsa: b53: always rejoin default untagged VLAN on bridge leave
authorJonas Gorski <jonas.gorski@gmail.com>
Tue, 29 Apr 2025 20:17:05 +0000 (22:17 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 18 May 2025 06:24:05 +0000 (08:24 +0200)
[ Upstream commit 13b152ae40495966501697693f048f47430c50fd ]

While JOIN_ALL_VLAN allows to join all VLANs, we still need to keep the
default VLAN enabled so that untagged traffic stays untagged.

So rejoin the default VLAN even for switches with JOIN_ALL_VLAN support.

Fixes: 48aea33a77ab ("net: dsa: b53: Add JOIN_ALL_VLAN support")
Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
Tested-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://patch.msgid.link/20250429201710.330937-7-jonas.gorski@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/dsa/b53/b53_common.c

index b257757f0b9dcf6d3676ee8abc1c06344f5b6899..aa449fa1826839b11fd0f49a7cb052aa8427bab9 100644 (file)
@@ -2002,12 +2002,12 @@ void b53_br_leave(struct dsa_switch *ds, int port, struct dsa_bridge bridge)
                if (!(reg & BIT(cpu_port)))
                        reg |= BIT(cpu_port);
                b53_write16(dev, B53_VLAN_PAGE, B53_JOIN_ALL_VLAN_EN, reg);
-       } else {
-               b53_get_vlan_entry(dev, pvid, vl);
-               vl->members |= BIT(port) | BIT(cpu_port);
-               vl->untag |= BIT(port) | BIT(cpu_port);
-               b53_set_vlan_entry(dev, pvid, vl);
        }
+
+       b53_get_vlan_entry(dev, pvid, vl);
+       vl->members |= BIT(port) | BIT(cpu_port);
+       vl->untag |= BIT(port) | BIT(cpu_port);
+       b53_set_vlan_entry(dev, pvid, vl);
 }
 EXPORT_SYMBOL(b53_br_leave);