Fix, check for NULL pointer before state object cleanup and free.

Coverity checker picked up, StatefulRequest pointer having child fields
and CBDATA cleaned up then itself freed, even if it was NULL to start with.

diff --git a/src/helper.cc b/src/helper.cc
index 9de06437a335d7c6eab08949860e4248fdd09b3a..c7b4377f58d140b14b6c54800bc5c1502eb8f0cf 100644 (file)
--- a/src/helper.cc
+++ b/src/helper.cc
@@ -1,6 +1,6 @@
 
 /*
- * $Id: helper.cc,v 1.86 2007/08/03 02:22:52 amosjeffries Exp $
+ * $Id: helper.cc,v 1.87 2007/08/04 03:19:12 amosjeffries Exp $
  *
  * DEBUG: section 84    Helper process maintenance
  * AUTHOR: Harvest Derived?
@@ -1602,9 +1602,11 @@ helperRequestFree(helper_request * r)
 static void
 helperStatefulRequestFree(helper_stateful_request * r)
 {
-    cbdataReferenceDone(r->data);
-    xfree(r->buf);
-    delete r;
+    if(r) {
+        cbdataReferenceDone(r->data);
+        xfree(r->buf);
+        delete r;
+    }
 }
 
 // TODO: should helper_ and helper_stateful_ have a common parent?