]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
libcli/security: test_run_condtional_ace: va_end() on errors
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Thu, 28 Sep 2023 23:25:21 +0000 (12:25 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Fri, 29 Sep 2023 02:18:34 +0000 (02:18 +0000)
CID 1545154, CID 1545155.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
libcli/security/tests/test_run_conditional_ace.c

index f8500275148c184360ec0a809a1c095491b0dd08..c538b7cb55e0ff267bf4217c94cbbf92c7079938 100644 (file)
@@ -77,6 +77,7 @@ static bool fill_token_claims(TALLOC_CTX *mem_ctx,
                                                    name,
                                                    str);
                if (claim == NULL) {
+                       va_end(args);
                        debug_fail("bad claim: %s\n", str);
                        return false;
                }
@@ -117,6 +118,7 @@ static bool fill_token_sids(TALLOC_CTX *mem_ctx,
                sid = sddl_decode_sid(mem_ctx, &str, NULL);
                if (sid == NULL) {
                        debug_fail("bad SID: %s\n", str);
+                       va_end(args);
                        return false;
                }
                add_sid_to_array(mem_ctx, sid, list, n);