]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
eeprom: at24: Use dev_err_probe for nvmem register failure
authorAlexander Stein <alexander.stein@ew.tq-group.com>
Tue, 16 May 2023 08:05:53 +0000 (10:05 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 May 2024 09:47:57 +0000 (11:47 +0200)
[ Upstream commit a3c10035d12f5ec10915d5c00c2e8f7d7c066182 ]

When using nvmem layouts it is possible devm_nvmem_register returns
-EPROBE_DEFER, resulting in an 'empty' in
/sys/kernel/debug/devices_deferred. Use dev_err_probe for providing
additional information.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Stable-dep-of: f42c97027fb7 ("eeprom: at24: fix memory corruption race condition")
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/misc/eeprom/at24.c

index 305ffad131a2997bd70e72184a06374b20b8cdcc..b100bbc888668cf1cb60a3d34a8e53966de9ecfb 100644 (file)
@@ -762,7 +762,8 @@ static int at24_probe(struct i2c_client *client)
                pm_runtime_disable(dev);
                if (!pm_runtime_status_suspended(dev))
                        regulator_disable(at24->vcc_reg);
-               return PTR_ERR(at24->nvmem);
+               return dev_err_probe(dev, PTR_ERR(at24->nvmem),
+                                    "failed to register nvmem\n");
        }
 
        /*