]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
bus-proxy: allow empty arguments to UpdateActivationEnvironment() v224
authorDavid Herrmann <dh.herrmann@gmail.com>
Fri, 31 Jul 2015 16:56:38 +0000 (18:56 +0200)
committerDavid Herrmann <dh.herrmann@gmail.com>
Fri, 31 Jul 2015 16:56:38 +0000 (18:56 +0200)
There is no reason to prevent empty argument lists on
UpdateActivationEnvironment(). Make sure we don't fail, but still skip
the call to pid1.

src/bus-proxyd/driver.c

index ad164a5e02422a1da311cc0b3b65a713652fb45f..951f5158087906f6efe6ada3406ded656d4b3d5c 100644 (file)
@@ -707,8 +707,8 @@ int bus_proxy_process_driver(Proxy *p, sd_bus *a, sd_bus *b, sd_bus_message *m,
                 if (r < 0)
                         return synthetic_reply_method_errno(m, r, NULL);
 
-                if (!args)
-                        return synthetic_reply_method_errno(m, -EINVAL, NULL);
+                if (strv_isempty(args)) /* nothing to do? */
+                        return synthetic_reply_method_return(m, NULL);
 
                 r = sd_bus_message_new_method_call(
                                 a,