Don't spam controllers with TOO_MANY_CONNECTIONS events

We implemented ratelimiting for warnings going into the logfile, but didn't
rate-limit controller events. Now both log warnings and controller events
are rate-limited.

diff --git a/ChangeLog b/ChangeLog
index 339402b9268eb411771777b7be51182ed4ad6d23..476c217e4e2aeb5d40e5d8ef64c32fd02e0eb5d1 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -15,6 +15,9 @@ Changes in version 0.2.2.9-alpha - 2010-??-??
     - Actually reject .exit hostnames when we're supposed to be rejecting
       them; do not pass them on to the exit server.  Bugfix on 0.2.2.7-alpha;
       found and diagnosed by Scott Bennett and Downie on or-talk.
+    - Don't spam the controller with log messages when we have no file
+      descriptors available. Rate-limiting for log messages was already
+      implemented in the past.
 
   o Code simplifications and refactoring:
     - Generate our manpage and HTML documentation using Asciidoc.  This

diff --git a/src/or/connection.c b/src/or/connection.c
index eeb25c1828c24977bdf0581d5b1e75c837754fc8..cf13345741b5227b7fbd11612eb099d52eb16917 100644 (file)
--- a/src/or/connection.c
+++ b/src/or/connection.c
@@ -822,9 +822,9 @@ warn_too_many_conns(void)
     log_warn(LD_NET,"Failing because we have %d connections already. Please "
              "raise your ulimit -n.", n_conns);
     last_warned = now;
+    control_event_general_status(LOG_WARN, "TOO_MANY_CONNECTIONS CURRENT=%d",
+                                 n_conns);
   }
-  control_event_general_status(LOG_WARN, "TOO_MANY_CONNECTIONS CURRENT=%d",
-                               n_conns);
 }
 
 /** Bind a new non-blocking socket listening to the socket described