s3:mdssvc: close mdssvc rpc command must return in handle

Checked against macOS mdssvc.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/selftest/knownfail.d/samba3.rpc b/selftest/knownfail.d/samba3.rpc
index bafc9c3ece0b21c8adca6c2644fc0c017b308ba3..103c99436f1b0c13177738f7b8cbaee8b4aec9cd 100644 (file)
--- a/selftest/knownfail.d/samba3.rpc
+++ b/selftest/knownfail.d/samba3.rpc
@@ -1,2 +1 @@
-^samba3.rpc.mdssvc.rpccmd.close\(fileserver\)
 ^samba3.rpc.mdssvc.mdscmd.fetch_unknown_cnid\(fileserver\)

diff --git a/source3/rpc_server/mdssvc/srv_mdssvc_nt.c b/source3/rpc_server/mdssvc/srv_mdssvc_nt.c
index 9e869dd3427edd8e9e74b98abf9ff5c48831bbd3..0e8e9c68bd75b42efc001d16f43ce71c256b9355 100644 (file)
--- a/source3/rpc_server/mdssvc/srv_mdssvc_nt.c
+++ b/source3/rpc_server/mdssvc/srv_mdssvc_nt.c
@@ -317,9 +317,9 @@ void _mdssvc_close(struct pipes_struct *p, struct mdssvc_close *r)
 
        DEBUG(10, ("%s: path: %s\n", __func__, mds_ctx->spath));
 
+       *r->out.out_handle = r->in.in_handle;
        close_policy_hnd(p, &r->in.in_handle);
 
-       ZERO_STRUCTP(r->out.out_handle);
        *r->out.status = 0;
 
        return;