Coverity 1038123: memory leak on 'flowint' keyword parsing failure

diff --git a/src/detect-flowint.c b/src/detect-flowint.c
index de34e93bca0fe36d21e68a8c3ec8e8edc1b55d66..079417472552be0531ff8a292923a9085f7fa783 100644 (file)
--- a/src/detect-flowint.c
+++ b/src/detect-flowint.c
@@ -394,13 +394,17 @@ static int DetectFlowintSetup(DetectEngineCtx *de_ctx, Signature *s, char *rawst
         case FLOWINT_MODIFIER_NOTSET:
             SigMatchAppendSMToList(s, sm, DETECT_SM_LIST_MATCH);
             break;
+        default:
+            goto error;
     }
 
     return 0;
 
 error:
-    if (sfd) DetectFlowintFree(sfd);
-    if (sm) SCFree(sm);
+    if (sfd)
+        DetectFlowintFree(sfd);
+    if (sm)
+        SCFree(sm);
     return -1;
 }