]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
smbd: Turn an if-statement getting reparse points into a switch
authorVolker Lendecke <vl@samba.org>
Fri, 5 Jul 2024 15:31:19 +0000 (17:31 +0200)
committerJeremy Allison <jra@samba.org>
Fri, 12 Jul 2024 20:35:34 +0000 (20:35 +0000)
There will be more cases soon

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/modules/util_reparse.c

index fce3603e7808bf19dc8303060abfb4d26df672ee..5c7ae670d0bfa7c8380e39272829775b6cb08d8b 100644 (file)
@@ -93,10 +93,14 @@ NTSTATUS fsctl_get_reparse_point(struct files_struct *fsp,
                return NT_STATUS_NOT_A_REPARSE_POINT;
        }
 
-       if (S_ISREG(fsp->fsp_name->st.st_ex_mode)) {
+       switch (fsp->fsp_name->st.st_ex_mode & S_IFMT) {
+       case S_IFREG:
                DBG_DEBUG("%s is a regular file\n", fsp_str_dbg(fsp));
                status = fsctl_get_reparse_point_reg(
                        fsp, mem_ctx, &out_data, max_out_len, &out_len);
+               break;
+       default:
+               break;
        }
 
        if (!NT_STATUS_IS_OK(status)) {