]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: netpoll: remove unused netpoll pointer from netpoll_info
authorBreno Leitao <leitao@debian.org>
Thu, 18 Sep 2025 12:25:57 +0000 (05:25 -0700)
committerJakub Kicinski <kuba@kernel.org>
Sat, 20 Sep 2025 00:50:59 +0000 (17:50 -0700)
The netpoll_info structure contains an useless pointer back to its
associated netpoll. This field is never used, and the assignment in
__netpoll_setup() is does not comtemplate multiple instances, as
reported by Jay[1].

Drop both the member and its initialization to simplify the structure.

Link: https://lore.kernel.org/all/2930648.1757463506@famine/
Signed-off-by: Breno Leitao <leitao@debian.org>
Link: https://patch.msgid.link/20250918-netpoll_jv-v1-1-67d50eeb2c26@debian.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/linux/netpoll.h
net/core/netpoll.c

index b5ea9882eda8b42f6ab115749a3d986829d334ff..f22eec4660405eaa654eb7746cbfdc89113fe312 100644 (file)
@@ -55,7 +55,6 @@ struct netpoll_info {
 
        struct delayed_work tx_work;
 
-       struct netpoll *netpoll;
        struct rcu_head rcu;
 };
 
index 5f65b62346d4e4abe02c60e9f88e03e0e75bf4b7..c58faa747165066b9424bb28a3165a024ed74df8 100644 (file)
@@ -591,7 +591,6 @@ int __netpoll_setup(struct netpoll *np, struct net_device *ndev)
 
        np->dev = ndev;
        strscpy(np->dev_name, ndev->name, IFNAMSIZ);
-       npinfo->netpoll = np;
 
        /* fill up the skb queue */
        refill_skbs(np);