]> git.ipfire.org Git - thirdparty/knot-resolver.git/commitdiff
lint: daemon/network.c: replaced NULL argument for 'setsockopt'
authorAleš Mrázek <ales.mrazek@nic.cz>
Fri, 22 Aug 2025 12:42:26 +0000 (14:42 +0200)
committerVladimír Čunát <vladimir.cunat@nic.cz>
Wed, 27 Aug 2025 06:57:15 +0000 (08:57 +0200)
The 4th argument to 'setsockopt' should not be NULL, clang-tidy clang-analyzer-unix.StdCLibraryFunctions error.

daemon/network.c

index 9bedfc929924e80c8c0242e6f6d5da57a26c935b..d4088bbaa5cdb874e31a4ddc75e221dc2a8f8b23 100644 (file)
@@ -919,7 +919,8 @@ static int clear_bpf_cb(trie_val_t *val, void *ctx)
                        uv_fileno(endpoint->handle, &sockfd);
                kr_require(sockfd != -1);
 
-               if (setsockopt(sockfd, SOL_SOCKET, SO_DETACH_BPF, NULL, 0) != 0) {
+               int no = 0;
+               if (setsockopt(sockfd, SOL_SOCKET, SO_DETACH_BPF, &no, sizeof(no)) != 0) {
                        kr_log_error(NETWORK, "failed to clear SO_DETACH_BPF socket option\n");
                }
                /* Proceed even if setsockopt() failed,