]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
pinctrl: armada-37xx: propagate error from armada_37xx_pmx_set_by_name()
authorGabor Juhos <j4g8y7@gmail.com>
Wed, 14 May 2025 19:18:38 +0000 (21:18 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Jun 2025 10:04:18 +0000 (11:04 +0100)
[ Upstream commit 4229c28323db141eda69cb99427be75d3edba071 ]

The regmap_update_bits() function can fail, so propagate its error
up to the stack instead of silently ignoring that.

Signed-off-by: Imre Kaloz <kaloz@openwrt.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
Link: https://lore.kernel.org/20250514-pinctrl-a37xx-fixes-v2-7-07e9ac1ab737@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pinctrl/mvebu/pinctrl-armada-37xx.c

index d74d280447bff654cf61428d3584b48451b31ab7..b17d0e80f25afba1d67cd378f29744cf31fcad56 100644 (file)
@@ -354,9 +354,7 @@ static int armada_37xx_pmx_set_by_name(struct pinctrl_dev *pctldev,
 
        val = grp->val[func];
 
-       regmap_update_bits(info->regmap, reg, mask, val);
-
-       return 0;
+       return regmap_update_bits(info->regmap, reg, mask, val);
 }
 
 static int armada_37xx_pmx_set(struct pinctrl_dev *pctldev,