hwclock: remove custom errno string

Custom errno messages are unnecessary and problematic for translators.

hwclock --directisa
hwclock: iopl() port access failed: Operation not permitted
hwclock: root privileges may be required

The custom errno message is misleading. We do not know what
the system permissions are set to. The default errno string is
correct, and enough.

Patched:
hwclock --directisa
hwclock: iopl() port access failed: Operation not permitted

root@:~# hwclock --directisa -D
Using direct ISA access to the clock
2017-07-24 14:49:17.782716-0400

Signed-off-by: J William Piggott <elseifthen@gmx.com>

diff --git a/sys-utils/hwclock-cmos.c b/sys-utils/hwclock-cmos.c
index 6227b94c0f64da6d9499672b428211589d47cbb9..cdbc88b03ac74eef8e1763bb77b3cf6b5f0d7e43 100644 (file)
--- a/sys-utils/hwclock-cmos.c
+++ b/sys-utils/hwclock-cmos.c
@@ -45,7 +45,6 @@
  *   tm_isdst  >0: yes, 0: no, <0: unknown
  */
 
-#include <errno.h>
 #include <fcntl.h>
 #include <stdio.h>
 #include <string.h>
@@ -390,12 +389,9 @@ static int get_permissions_cmos(void)
        if (rc == IOPL_NOT_IMPLEMENTED) {
                warnx(_("ISA port access is not implemented"));
        } else if (rc != 0) {
-               rc = errno;
                warn(_("iopl() port access failed"));
-               if (rc == EPERM && geteuid())
-                       warnx(_("root privileges may be required"));
        }
-       return rc ? 1 : 0;
+       return rc;
 }
 
 static struct clock_ops cmos_interface = {

diff --git a/sys-utils/hwclock.h b/sys-utils/hwclock.h
index a1ef80cee800dd5085c325653f800a98f45e2946..8843501f3bf728a3ad5d2f8fc62382bf8dc143a8 100644 (file)
--- a/sys-utils/hwclock.h
+++ b/sys-utils/hwclock.h
@@ -1,7 +1,6 @@
 #ifndef HWCLOCK_CLOCK_H
 #define HWCLOCK_CLOCK_H
 
-#include <errno.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>